Added Okta provider support with private key JWT authentication#31
Closed
hixichen wants to merge 4 commits intoopenbao:mainfrom
Closed
Added Okta provider support with private key JWT authentication#31hixichen wants to merge 4 commits intoopenbao:mainfrom
hixichen wants to merge 4 commits intoopenbao:mainfrom
Conversation
- Implement Okta OAuth2 provider supporting both client secret and private key JWT authentication methods - Add support for client_credentials grant type using Private Key JWT (RFC 7523) - Include comprehensive test coverage for both authentication methods - Update documentation with Okta configuration examples 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add better error handling with errmark.MarkUser for authentication failures - Add input validation for client ID in JWT assertion creation - Add HTTP client timeout configuration (30s) - Add comprehensive test coverage for client secret authentication - Add security constants for JWT lifetime limits 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Test Coverage Improvements: - Add comprehensive tests for OktaFactory with various configurations - Add tests for refresh token functionality - Add error scenario tests for ClientCredentials method - Add JWT creation error tests (missing client ID, no private key) - Add tests for provider methods (Version, Public, AuthCodeURL) - Coverage improved from 69.7% to 88.0% for OktaFactory - Coverage improved from 75.6% to 87.8% for ClientCredentials - Coverage improved from 0% to 85.7% for AuthCodeURL - Coverage improved from 0% to 88.9% for RefreshToken Documentation Improvements: - Add comprehensive Okta provider section to README - Document both client secret and private key JWT authentication methods - Include configuration examples and usage notes - Add security recommendations and technical details - Document supported OAuth2 flows and requirements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use content from 'Client credentials with Private Key JWT Authentication' section - Maintain consistency with existing documentation format - Keep the same configuration examples and output format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
DrDaveD
requested changes
Sep 29, 2025
Member
|
Hello @hixichen |
Author
|
Thanks for the clarification on the AI policy! Just to make sure I fully understand the DCO requirement: does this mean every line must be manually typed, or is standard IDE autocomplete acceptable as long as generative AI plugins are disabled? |
Member
|
Hey @hixichen! No, you can use autocomplete. Its just that we want to avoid blocks of AI generated code. You can see some more about that here: https://github.com/openbao/openbao/tree/main/CONTRIBUTING.md and https://openbao.org/docs/contributing/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Okta provider with private key JWT authentication support